Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggy sound in GB/GBC #768

Closed
sergiobenrocha2 opened this issue Jun 30, 2017 · 5 comments
Closed

Buggy sound in GB/GBC #768

sergiobenrocha2 opened this issue Jun 30, 2017 · 5 comments
Labels
hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues
Milestone
0.6.0

Comments

@sergiobenrocha2
Copy link
Contributor

sergiobenrocha2 commented Jun 30, 2017 •
edited
Loading

1 - Load a GBA game (sound is fine)
2 - Load a GB/GBC game, you'll notice buggy sound / static noise in every GB/GBC game you load now
3 - Try record it in Record Output, it'll not get the buggy sound

If you first load a GB/GBC game, it'll be fine

Xubuntu 17.04
@endrift
Copy link
Member

endrift commented Jun 30, 2017

I can't trivially reproduce this on macOS. Can you be more specific, e.g. which GBA and GB games? Or are you having it with just any?

@sergiobenrocha2
Copy link
Contributor Author

No, the noise is only in GB/GBC games. You can load a GBA game again, no noise

@endrift endrift modified the milestone: 0.6.0 Jun 30, 2017
@endrift endrift added hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues labels Jun 30, 2017
@sergiobenrocha2
Copy link
Contributor Author

sergiobenrocha2 commented Jul 7, 2017 •
edited
Loading

You now have to:

1 - Load a GBA game (sound is fine)
2 - Load a GB/GBC game
3 - Load a GBA game again
4 - Load a GB/GBC game, you'll notice the bug

You'll notice better with Pokemon Pinball (GBC)

@endrift
Copy link
Member

endrift commented Jul 8, 2017

Still can't reproduce on macOS. Will try again on Linux before releasing beta 2.

@endrift endrift closed this as completed in 6916009 Jul 9, 2017
endrift added a commit that referenced this issue Jul 9, 2017
@endrift
SDL: Remove writing back obtained samples (fixes #768)
584d374
@endrift
Copy link
Member

endrift commented Jul 9, 2017

Looks like it's an SDL bug. I had to work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@endrift @sergiobenrocha2