New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI language selector _severly_ broken #776

Closed
lotharsm opened this Issue Jul 3, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@lotharsm
Member

lotharsm commented Jul 3, 2017

The GUI language selector seems to be broken. On my Windows system, the menu entries in the main mGBA window are translated correctly, but each and every other dialog in mGBA always is displayed in english, no matter what language I choose in the Interface options.

After clicking "OK" and/or "Apply" and restarting mGBA, the main mGBA keeps the language I selected, but all other dialogs are still in english. It should be noted that after restarting mGBA, the language option in the "Interface" tab always falls back to English, no matter what I previously selected.

OS: Windows 10
mGBA revision da50382, compiled by myself

mgba language bug

@endrift endrift modified the milestone: 0.6.0 Jul 4, 2017

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jul 5, 2017

Member

(Partially?) fixed by db08a75.

Member

endrift commented Jul 5, 2017

(Partially?) fixed by db08a75.

@lotharsm

This comment has been minimized.

Show comment
Hide comment
@lotharsm

lotharsm Jul 5, 2017

Member

Sadly, the fix doesn't work for me. The language= entry in qt.ini will not be created. Manually adding it doesn't help either. As before, the main menu items are translated, the rest of the UI is still English.

Compared to previous commits, this time the pulldown menu seems to remember the language you selected if you do this manually by setting language= in qt.ini. Again, even setting it manually doesn't help with the dialogs being untranslated.

Member

lotharsm commented Jul 5, 2017

Sadly, the fix doesn't work for me. The language= entry in qt.ini will not be created. Manually adding it doesn't help either. As before, the main menu items are translated, the rest of the UI is still English.

Compared to previous commits, this time the pulldown menu seems to remember the language you selected if you do this manually by setting language= in qt.ini. Again, even setting it manually doesn't help with the dialogs being untranslated.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Jul 6, 2017

Member

Not sure what's going on with the dialogs, but it's supposed to use the default locale of your computer the first time you run it. Also, if you don't change the locale from your default, it's not supposed to make the key. I deleted the language key and set my Windows 10 machine to German (de_DE specifically) and when I started it I got the de translation. Setting it to English set it to the default en. Deleting the key again and setting it to de didn't set the key. So everything seems to work fine on my end apart from the dialogs.

Also some of the dialogs are translated (e.g. the log view), but many are not and I have no idea what's going on there.

Member

endrift commented Jul 6, 2017

Not sure what's going on with the dialogs, but it's supposed to use the default locale of your computer the first time you run it. Also, if you don't change the locale from your default, it's not supposed to make the key. I deleted the language key and set my Windows 10 machine to German (de_DE specifically) and when I started it I got the de translation. Setting it to English set it to the default en. Deleting the key again and setting it to de didn't set the key. So everything seems to work fine on my end apart from the dialogs.

Also some of the dialogs are translated (e.g. the log view), but many are not and I have no idea what's going on there.

@lotharsm

This comment has been minimized.

Show comment
Hide comment
@lotharsm

lotharsm Jul 6, 2017

Member

Fix confirmed. Thank you!

Member

lotharsm commented Jul 6, 2017

Fix confirmed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment