New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRAM saves are incorrect size. #883

Closed
cheatfreak47 opened this Issue Sep 23, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@cheatfreak47

cheatfreak47 commented Sep 23, 2017

SRAM / FRAM saves should be 32KB in size, fixing this would not break compatibility with VBA save either I don't think, as those simply pad out the extra 32KB with FF bytes, to fix that, simply accept 64KB saves for SRAM and when outputting a new save, overwrite it with 32KB.

This shouldn't matter really but I figured it was worth mentioning anyway.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Sep 23, 2017

Member

...wait what

Member

endrift commented Sep 23, 2017

...wait what

@cheatfreak47

This comment has been minimized.

Show comment
Hide comment
@cheatfreak47

cheatfreak47 Sep 23, 2017

Yep, that's how it is, the Static RAM chip or Ferroelectric RAM chips used in GBA games are only ever have 32kb of actual storage, If games need 64KB of storage, they use FLASH512kbit (64KB) chips.

cheatfreak47 commented Sep 23, 2017

Yep, that's how it is, the Static RAM chip or Ferroelectric RAM chips used in GBA games are only ever have 32kb of actual storage, If games need 64KB of storage, they use FLASH512kbit (64KB) chips.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Sep 23, 2017

Member

how did I never know that

Member

endrift commented Sep 23, 2017

how did I never know that

@cheatfreak47

This comment has been minimized.

Show comment
Hide comment
@cheatfreak47

cheatfreak47 Sep 23, 2017

¯\(º_o)/¯
I think VBA-M is still doing this wrong too actually, I should make an issue on their tracker
but I like mGBA more ^_^

the 3DS AGBFIRM mode gets this right since it's effectively a real GBA, it's files are only 32kb.

cheatfreak47 commented Sep 23, 2017

¯\(º_o)/¯
I think VBA-M is still doing this wrong too actually, I should make an issue on their tracker
but I like mGBA more ^_^

the 3DS AGBFIRM mode gets this right since it's effectively a real GBA, it's files are only 32kb.

@endrift endrift closed this in 5dfa036 Sep 23, 2017

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Sep 23, 2017

Member

I dug through a bunch of my SRAM saves and verified. I'm not sure how OOB works yet so I'm not gonna backport this to 0.6.1 until I do.

Member

endrift commented Sep 23, 2017

I dug through a bunch of my SRAM saves and verified. I'm not sure how OOB works yet so I'm not gonna backport this to 0.6.1 until I do.

@cheatfreak47

This comment has been minimized.

Show comment
Hide comment
@cheatfreak47

cheatfreak47 Sep 23, 2017

@endrift http://problemkaputt.de/gbatek.htm#gbacartbackupsramfram there's some really good data on this page if you want to read up sometime.

cheatfreak47 commented Sep 23, 2017

@endrift http://problemkaputt.de/gbatek.htm#gbacartbackupsramfram there's some really good data on this page if you want to read up sometime.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Sep 23, 2017

Member

You say that as though I don't have that as a pinned tab and have for years ;)

Member

endrift commented Sep 23, 2017

You say that as though I don't have that as a pinned tab and have for years ;)

@sergiobenrocha2

This comment has been minimized.

Show comment
Hide comment
@sergiobenrocha2

sergiobenrocha2 Sep 30, 2017

Contributor

Qt frontend is not changing from 64 to 32 kB automatically. You get 32 kB only with new saves.

Contributor

sergiobenrocha2 commented Sep 30, 2017

Qt frontend is not changing from 64 to 32 kB automatically. You get 32 kB only with new saves.

@endrift

This comment has been minimized.

Show comment
Hide comment
@endrift

endrift Sep 30, 2017

Member

Yeah, the frontend will never shrink files. It's not really a big deal I don't think.

Member

endrift commented Sep 30, 2017

Yeah, the frontend will never shrink files. It's not really a big deal I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment