Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lufia: The Ruins of Lore Intro text not rendered properly #899

Closed
Krusher97 opened this issue Oct 6, 2017 · 5 comments
Closed

Lufia: The Ruins of Lore Intro text not rendered properly #899

Krusher97 opened this issue Oct 6, 2017 · 5 comments
Labels
platform:GBA
Milestone
mGBA 0.6.2

Comments

@Krusher97
Copy link

@Krusher97 Krusher97 commented Oct 6, 2017

test
https://youtu.be/AvBapnXVv9k?t=8s

The gif is how it looks in the latest development build.
The video is how its supposed to look.
@endrift
Copy link
Member

@endrift endrift commented Oct 11, 2017

Seems to be the same root cause as #142, namely using DMA from invalid memory to read out zeroes.

@endrift endrift closed this in 0225803 Oct 11, 2017
@endrift endrift added this to the mGBA 0.6.2 milestone Oct 11, 2017
@CharlesCorrin
Copy link

@CharlesCorrin CharlesCorrin commented Oct 11, 2017

Should this be closed now? The latest revision (Revision 4873-66ce106) still has the bug.

@endrift
Copy link
Member

@endrift endrift commented Oct 11, 2017

It was definitely fixed locally. I’ll investigate later today.

@endrift endrift reopened this Oct 11, 2017
@CharlesCorrin
Copy link

@CharlesCorrin CharlesCorrin commented Oct 11, 2017

The commit where it says the bug was fixed:
0225803

It seems to change nothing but the changelog. Is that the reason?

@endrift endrift closed this in 17dac64 Oct 11, 2017
@endrift
Copy link
Member

@endrift endrift commented Oct 11, 2017

Good catch. Fixed now.

endrift added a commit that referenced this issue Nov 2, 2017
@endrift
Revert "GBA Video: Don't mask out high bits of BLDY (fixes #899)"
ea9af9e 
This reverts commit 17dac64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GBA
Projects
None yet
Milestone
mGBA 0.6.2
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@endrift @waddlesplash @CharlesCorrin @Krusher97