Build failure with ffmpeg git master

[orbea]

I'm using the ffmpeg 3f234a0 2018.01.08 commit because of other programs now requiring it and I found the mgba git master now does not build.

/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c: In function ‘FFmpegEncoderOpen’:
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:232:29: error: ‘CODEC_FLAG_GLOBAL_HEADER’ undeclared (first use in this function); did you mean ‘AV_CODEC_FLAG_GLOBAL_HEADER’?
    encoder->audio->flags |= CODEC_FLAG_GLOBAL_HEADER;
                             ^~~~~~~~~~~~~~~~~~~~~~~~
                             AV_CODEC_FLAG_GLOBAL_HEADER
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:232:29: note: each undeclared identifier is reported only once for each function it appears in
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:247:3: warning: ‘avresample_alloc_context’ is deprecated [-Wdeprecated-declarations]
   encoder->resampleContext = avresample_alloc_context();
   ^~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:194:25: note: declared here
 AVAudioResampleContext *avresample_alloc_context(void);
                         ^~~~~~~~~~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:254:3: warning: ‘avresample_open’ is deprecated [-Wdeprecated-declarations]
   avresample_open(encoder->resampleContext);
   ^~~~~~~~~~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:214:5: note: declared here
 int avresample_open(AVAudioResampleContext *avr);
     ^~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c: In function ‘FFmpegEncoderClose’:
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:357:4: warning: ‘avresample_close’ is deprecated [-Wdeprecated-declarations]
    avresample_close(encoder->resampleContext);
    ^~~~~~~~~~~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:245:6: note: declared here
 void avresample_close(AVAudioResampleContext *avr);
      ^~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c: In function ‘_ffmpegPostAudioFrame’:
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:409:2: warning: ‘avresample_convert’ is deprecated [-Wdeprecated-declarations]
  avresample_convert(encoder->resampleContext, 0, 0, 0,
  ^~~~~~~~~~~~~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:451:5: note: declared here
 int avresample_convert(AVAudioResampleContext *avr, uint8_t **output,
     ^~~~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:413:2: warning: ‘avresample_available’ is deprecated [-Wdeprecated-declarations]
  if (avresample_available(encoder->resampleContext) < encoder->audioFrame->nb_samples) {
  ^~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:494:5: note: declared here
 int avresample_available(AVAudioResampleContext *avr);
     ^~~~~~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:419:2: warning: ‘avresample_read’ is deprecated [-Wdeprecated-declarations]
  int samples = avresample_read(encoder->resampleContext, encoder->audioFrame->data, encoder->postaudioBufferSize / channelSize);
  ^~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:517:5: note: declared here
 int avresample_read(AVAudioResampleContext *avr, uint8_t **output, int nb_samples);
     ^~~~~~~~~~~~~~~
[ 51%] Building C object CMakeFiles/mgba.dir/src/gb/debugger/cli.c.o
make[2]: *** [CMakeFiles/mgba.dir/build.make:3015: CMakeFiles/mgba.dir/src/feature/ffmpeg/ffmpeg-encoder.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/tmp/SBo/mgba/src/debugger/cli-debugger.c: In function ‘CLIDebuggerTabComplete’:
/tmp/SBo/mgba/src/debugger/cli-debugger.c:929:83: warning: unused parameter ‘initial’ [-Wunused-parameter]
 bool CLIDebuggerTabComplete(struct CLIDebugger* debugger, const char* token, bool initial, size_t tokenLen) {
                                                                                   ^~~~~~~
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/mgba.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Full build log - https://pastebin.com/HnQL8D3q

[orbea]

Still failing to build.

/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c: In function ‘FFmpegEncoderOpen’:
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:232:29: error: ‘CODEC_FLAG_GLOBAL_HEADER’ undeclared (first use in this function); did you mean ‘AV_CODEC_FLAG_GLOBAL_HEADER’?
    encoder->audio->flags |= CODEC_FLAG_GLOBAL_HEADER;
                             ^~~~~~~~~~~~~~~~~~~~~~~~
                             AV_CODEC_FLAG_GLOBAL_HEADER
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:232:29: note: each undeclared identifier is reported only once for each function it appears in
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:247:3: warning: ‘avresample_alloc_context’ is deprecated [-Wdeprecated-declarations]
   encoder->resampleContext = avresample_alloc_context();
   ^~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:194:25: note: declared here
 AVAudioResampleContext *avresample_alloc_context(void);
                         ^~~~~~~~~~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:254:3: warning: ‘avresample_open’ is deprecated [-Wdeprecated-declarations]
   avresample_open(encoder->resampleContext);
   ^~~~~~~~~~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:214:5: note: declared here
 int avresample_open(AVAudioResampleContext *avr);
     ^~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c: In function ‘FFmpegEncoderClose’:
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:361:4: warning: ‘avresample_close’ is deprecated [-Wdeprecated-declarations]
    avresample_close(encoder->resampleContext);
    ^~~~~~~~~~~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:245:6: note: declared here
 void avresample_close(AVAudioResampleContext *avr);
      ^~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c: In function ‘_ffmpegPostAudioFrame’:
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:413:2: warning: ‘avresample_convert’ is deprecated [-Wdeprecated-declarations]
  avresample_convert(encoder->resampleContext, 0, 0, 0,
  ^~~~~~~~~~~~~~~~~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:451:5: note: declared here
 int avresample_convert(AVAudioResampleContext *avr, uint8_t **output,
     ^~~~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:417:2: warning: ‘avresample_available’ is deprecated [-Wdeprecated-declarations]
  if (avresample_available(encoder->resampleContext) < encoder->audioFrame->nb_samples) {
  ^~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:494:5: note: declared here
 int avresample_available(AVAudioResampleContext *avr);
     ^~~~~~~~~~~~~~~~~~~~
/tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:423:2: warning: ‘avresample_read’ is deprecated [-Wdeprecated-declarations]
  int samples = avresample_read(encoder->resampleContext, encoder->audioFrame->data, encoder->postaudioBufferSize / channelSize);
  ^~~
In file included from /tmp/SBo/mgba/src/feature/ffmpeg/ffmpeg-encoder.c:22:0:
/usr/include/libavresample/avresample.h:517:5: note: declared here
 int avresample_read(AVAudioResampleContext *avr, uint8_t **output, int nb_samples);
     ^~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/mgba.dir/build.make:3015: CMakeFiles/mgba.dir/src/feature/ffmpeg/ffmpeg-encoder.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/tmp/SBo/mgba/src/gb/extra/proxy.c: In function ‘_reset’:
/tmp/SBo/mgba/src/gb/extra/proxy.c:65:77: warning: unused parameter ‘model’ [-Wunused-parameter]
 static void _reset(struct GBVideoProxyRenderer* proxyRenderer, enum GBModel model) {
                                                                             ^~~~~
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/mgba.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

[endrift]

Those line numbers correspond with the wrong branch. Please try master.

Oops I missed a line.

[endrift]

Should be actually fixed now. Sorry about that.

[orbea]

Yes, it builds now. Thanks for the quick fix!