Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QT: Better text colors in the debugger #1719

Closed
wants to merge 9 commits into from
Closed

QT: Better text colors in the debugger #1719

wants to merge 9 commits into from

Conversation

Mte90
Copy link
Contributor

@Mte90 Mte90 commented Apr 4, 2020

immagine
immagine

@Mte90 Mte90 changed the title QT: Command bold in the debugger output QT: Better text colors in th debugger Apr 4, 2020
@Mte90 Mte90 changed the title QT: Better text colors in th debugger QT: Better text colors in the debugger Apr 4, 2020
@Mte90
Copy link
Contributor Author

Mte90 commented Apr 4, 2020

Before that I continue to work on that is helpful? There is anything that I need to know to avoid code duplication?

I cannot find the definition of this method debugger->backend->printf to replicate the behaviour.

@@ -99,6 +99,7 @@ struct mDebuggerPlatform {
void (*deinit)(struct mDebuggerPlatform*);
void (*entered)(struct mDebuggerPlatform*, enum mDebuggerEntryReason, struct mDebuggerEntryInfo*);

bool (*supportHTML)(struct mDebuggerPlatform*);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably I can remove this line

@@ -6,7 +6,7 @@
<rect>
<x>0</x>
<y>0</y>
<width>480</width>
<width>508</width>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better round to 510

@endrift
Copy link
Member

endrift commented Apr 13, 2020

I'm not really interested making the backend support HTML just because the frontend can render it. HTML is bad here in a number of ways, and the debugger console is kind of temporary until the real debugger UI is done.

@endrift endrift closed this Apr 13, 2020
@Mte90
Copy link
Contributor Author

Mte90 commented Apr 14, 2020

I know that HTML is not very good but it was an easy way to get a better output and maybe also to open new integration to mgba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants