Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vita: Fix flickering when using frameskip #1822

Merged
merged 1 commit into from Aug 2, 2020
Merged

Conversation

gotoAndDie
Copy link

@gotoAndDie gotoAndDie commented Jul 20, 2020

This pull request should fix issue #1689. I've also reduced the size of vita2d_texture from 4 to 2; I haven't found anything that needs 4 buffers rather than 2, and interframe blending works with 2 buffers.

bool frameAvailable;
if (runner->core->platform(runner->core) == PLATFORM_GBA) {
struct GBA* gba = runner->core->board;
frameAvailable = gba->video.frameskipCounter <= 0;
Copy link
Member

@endrift endrift Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach. However, I don't like the idea of having to cast to a specific core to grab the frameskip counter. It's not generic, and I want to reduce the number of things peering into the cores, not increase. Not sure if there's a better approach however.

@endrift
Copy link
Member

@endrift endrift commented Aug 2, 2020

If I can't come up with a better solution I'll merge this PR (and into 0.8.3) and add an API for figuring out if there's been a new frame posted in 0.9 so this can be generalized.

@endrift endrift added this to the mGBA 0.8.3 milestone Aug 2, 2020
@endrift endrift merged commit 404b743 into mgba-emu:master Aug 2, 2020
2 checks passed
@endrift endrift linked an issue Aug 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants