Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVita: Fix flickering when using frameskip #1822
Merged
Conversation
| bool frameAvailable; | ||
| if (runner->core->platform(runner->core) == PLATFORM_GBA) { | ||
| struct GBA* gba = runner->core->board; | ||
| frameAvailable = gba->video.frameskipCounter <= 0; |
This comment has been minimized.
This comment has been minimized.
endrift
Jul 20, 2020
Member
Interesting approach. However, I don't like the idea of having to cast to a specific core to grab the frameskip counter. It's not generic, and I want to reduce the number of things peering into the cores, not increase. Not sure if there's a better approach however.
|
If I can't come up with a better solution I'll merge this PR (and into 0.8.3) and add an API for figuring out if there's been a new frame posted in 0.9 so this can be generalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gotoAndDie commentedJul 20, 2020
This pull request should fix issue #1689. I've also reduced the size of vita2d_texture from 4 to 2; I haven't found anything that needs 4 buffers rather than 2, and interframe blending works with 2 buffers.