Vita: Fix flickering when using frameskip - #1822
Merged
Merged
Conversation
endrift
reviewed
Jul 20, 2020
| bool frameAvailable; | ||
| if (runner->core->platform(runner->core) == PLATFORM_GBA) { | ||
| struct GBA* gba = runner->core->board; | ||
| frameAvailable = gba->video.frameskipCounter <= 0; |
Member
There was a problem hiding this comment.
Interesting approach. However, I don't like the idea of having to cast to a specific core to grab the frameskip counter. It's not generic, and I want to reduce the number of things peering into the cores, not increase. Not sure if there's a better approach however.
Member
|
If I can't come up with a better solution I'll merge this PR (and into 0.8.3) and add an API for figuring out if there's been a new frame posted in 0.9 so this can be generalized. |
endrift
added a commit
that referenced
this pull request
Aug 2, 2020
zenaror
pushed a commit
to zenaror/mgba
that referenced
this pull request
Sep 9, 2026
Vita: Fix flickering when using frameskip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should fix issue #1689. I've also reduced the size of vita2d_texture from 4 to 2; I haven't found anything that needs 4 buffers rather than 2, and interframe blending works with 2 buffers.