This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
implemented filesize compression for jSkin and gSkin #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a862604887a9b18878db9ce043e63bdb8b359343)
Instead of a list of weights, it is now a dictionary of weights, with the vertex number as key. This can reduce the file size to 3% of the size.
1. Don't prune unless it is a polygon mesh. It is possible to prune on nurbs, but it needs more bug-testing. For example, on nurbs, you can't just specify the transform node. It will fail. 2. Don't use polyEvaluate on nurbsSurfaces or nurbsCurves. Count the CVs instead. By making this change, you can now export and import skinning on nurbs or polygons. 3. It now counts all the CVs or vtxs on multiple shape nodes. But the file format does NOT support multiple shape nodes yet! Each individual shape node under a transform would get a separate skinCluster.
Test for basestring instead of str. Skin weights are working fine because it uses dict.get(str(vtx))
I was checking the type of the key for binary vs. json. There is no need. Just cast the key as an int.
|
Nice job ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a list of weights, it is now a dictionary of weights, with the vertex number as key. 0.0 weights are omitted from the data to save space. This can reduce the file size dramatically down to 3% of the size! When importing the missing keys, 0.0 skin weight is assumed.
Tested for backwards compatibility. This new functionality will still properly import older gSkin and jSkin files.
I made jSkin the default choice in the import and export fileDialog. Now that the file sizes are smaller, I believe jSkin is a superior choice, to give TDs the ability to edit the files directly.
Also updated to modern string formatting. And put all errors and warnings on single lines, instead of multi-line strings, for better readability.