Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm_2jnt_04: wrist align and plane normal #59

Closed
tokejepsen opened this issue Jul 2, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@tokejepsen
Copy link
Contributor

commented Jul 2, 2019

Problem

When using the wrist align feature, the wrist and the elbow can get twisted resulting in flipping.

Capture

@tokejepsen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

The problem is with the calculated normal, which does not take into account the rotation of the wrist.

My vector skills are not very good, so I'll need some help with this. I'm trying to setup a simple reproducible code, where I can visualize the problem and try to solve but I'm hitting a wall already with converting a vector to a rotation/matrix;

import pymel.core as pm

from mgear.core import primitive, vector, transform


guides = ["arm_L0_root", "arm_L0_elbow", "arm_L0_wrist"]
guides = [pm.PyNode(x) for x in guides]
positions = [x.getTranslation(space="world") for x in guides]

normal = vector.getPlaneNormal(positions[0], positions[1], positions[2])
@miquelcampos

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Hi @tokejepsen

I will check this as soon as I have a little time.

@tokejepsen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

This does not seem to be an issue anymore.

Could be that #58 solved this as well.

@tokejepsen tokejepsen closed this Jul 9, 2019

@miquelcampos

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Hi @tokejepsen How do you fix it?

@tokejepsen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

I honestly dont know, but the issue is not there anymore after rebuilding.

I suspect it might be related to #58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.