Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output named after standard event #474

Merged

Conversation

@gbilodeau
Copy link
Contributor

gbilodeau commented Dec 17, 2017

PR implementing #473
Event list was taken from https://developer.mozilla.org/en-US/docs/Web/Events

This is my first time submitting a pull request anywhere, apologies in advance for any errors!

Copy link
Owner

mgechev left a comment

LGTM. Left one comment only.



export class OutputMetadataWalker extends NgWalker {
private readonly standardEventNames = [

This comment has been minimized.

Copy link
@mgechev

mgechev Dec 18, 2017

Owner

Let's use hash map here for constant check.

… of array for constant time check
@mgechev mgechev merged commit ae3f07b into mgechev:master Dec 18, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@gbilodeau gbilodeau deleted the gbilodeau:no-output-named-after-standard-event branch Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.