Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for extracting version incorrectly from sdist filename containing dashes #146

Merged
merged 1 commit into from Sep 22, 2021

Conversation

zobayer1
Copy link
Contributor

This commit attempts to fix (#145) filename parsing to extract the version string correctly.

Checklist

  • Added test case
  • Tested wheel packaging

Copy link
Owner

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Shame about coveralls messing up all the CI results.

@zobayer1
Copy link
Contributor Author

Tests for py36 failed for my local machines too. I didn't dig much into it, sorry about that.

@mgedmin
Copy link
Owner

mgedmin commented Sep 21, 2021

Hm, I don't see any failures on py36 if I run tox on your branch in a local checkout. (Although that doesn't run the full test matrix with all the possible FORCE_TEST_VCS overrides.)

@mgedmin mgedmin merged commit 4beeefb into mgedmin:master Sep 22, 2021
27 checks passed
@zobayer1 zobayer1 deleted the fix_145 branch September 22, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants