New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param for output steam #24

Merged
merged 2 commits into from Jan 25, 2016

Conversation

Projects
None yet
2 participants
@d-sun-d
Copy link

d-sun-d commented Dec 22, 2015

Now user can specify uotput stream.

I used lib with this modification in case where debug cann't be in sys.stdout

Alexander Ryabchenko
@mgedmin

This comment has been minimized.

Copy link
Owner

mgedmin commented Dec 22, 2015

Thank you for the pull request!

I think output_stream is a bit too long. Let's call it file, like the Python 3 built-in print(..., file=sys.stdout) function.

The Travis CI build failure is caused by PEP-8 warnings:

./objgraph.py:172:80: E501 line too long (94 > 79 characters)
./objgraph.py:201:80: E501 line too long (84 > 79 characters)
./objgraph.py:242:80: E501 line too long (85 > 79 characters)
make: *** [lint] Error 1

and renaming output_stream to file should fix two of them. The third long line will need some wrapping.

Alexander Ryabchenko
@d-sun-d

This comment has been minimized.

Copy link

d-sun-d commented Jan 25, 2016

fix name and split big line

mgedmin added a commit that referenced this pull request Jan 25, 2016

Merge pull request #24 from d-sun-d/master
Add param for output steam

@mgedmin mgedmin merged commit 4f35b38 into mgedmin:master Jan 25, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgedmin

This comment has been minimized.

Copy link
Owner

mgedmin commented Jan 25, 2016

Thank you!

mgedmin added a commit that referenced this pull request Jan 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment