New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle file objects without encoding attribute set #6

Merged
merged 1 commit into from May 15, 2014

Conversation

Projects
None yet
2 participants
@jstasiak
Copy link
Contributor

jstasiak commented May 15, 2014

file.encoding attribute doesn't need to be present (https://docs.python.org/2/library/stdtypes.html#file.encoding), this patch makes objgraph work with Eventlet and monkey patching.

mgedmin added a commit that referenced this pull request May 15, 2014

Merge pull request #6 from smarkets/master
Handle file objects without encoding attribute set

@mgedmin mgedmin merged commit 999cbb9 into mgedmin:master May 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mgedmin

This comment has been minimized.

Copy link
Owner

mgedmin commented May 15, 2014

Thank you!

mgedmin added a commit that referenced this pull request May 15, 2014

@mgedmin

This comment has been minimized.

Copy link
Owner

mgedmin commented May 15, 2014

objgraph 1.8.1 is out with this fix.

@jstasiak

This comment has been minimized.

Copy link
Contributor

jstasiak commented May 15, 2014

Thank you, it's great to see it released so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment