Marius Gedminas
mgedmin

Organizations

@jenkinsci @zopefoundation @buildout @ProgrammersOfVilnius @gtimelog @akllt
Jul 8, 2016
mgedmin commented on pull request zopefoundation/zope.testrunner#43
@mgedmin

Mostly LGTM, just worried that optional subunit support will bitrot if the subunit tests aren't enabled by default (by which I mean Travis and tox

Jul 8, 2016
mgedmin commented on pull request zopefoundation/zope.testrunner#43
@mgedmin

Are we not testing subunit support on Travis?

Jul 8, 2016
mgedmin commented on pull request zopefoundation/zope.testrunner#43
@mgedmin

This bit seems underexplained.

Jul 7, 2016
@mgedmin

Good thing I hedged my answer with that IIRC then ;)

Jul 7, 2016
@mgedmin

I've no idea why this issue doesn't mention #9. Perhaps I'd forgotten it existed.

Jul 7, 2016
@mgedmin

IIRC everything zope.* 4.0.0alpha that isn't released yet was blocked on zope.testbrowser, which introduced an incompatible API (no more magic thre…

Jul 7, 2016
@mgedmin
Jul 5, 2016
@mgedmin
Jun 29, 2016
mgedmin commented on issue plone/buildout.coredev#139
@mgedmin

Actually, the one and only commit I made to plone.z3cform was replacing a copy of zc.buildout's bootstrap.py with a newer copy of bootstrap.py. Do …

Jun 29, 2016
mgedmin commented on pull request wummel/linkchecker#657
@mgedmin

This was fixed differently in c2ce810.

Jun 29, 2016
mgedmin commented on pull request wummel/linkchecker#662
@mgedmin

This was fixed differently in c2ce810.

Jun 29, 2016
mgedmin commented on pull request wummel/linkchecker#650
@mgedmin

A different fix was committed in c2ce810.

Jun 29, 2016
mgedmin commented on issue wummel/linkchecker#661
@mgedmin

Should be fixed with c2ce810.

Jun 29, 2016
mgedmin commented on issue wummel/linkchecker#649
@mgedmin

Should be fixed with c2ce810. Can we have a new release soon please?

Jun 28, 2016
@mgedmin

Given a persistent mapping pm, copy.copy(pm).data is pm.data, which means that the two PersistentMapping instances always[*] share the same data. O…

Jun 28, 2016
mgedmin commented on pull request certbot/certbot#3213
@mgedmin

Other than that typo, LGTM.

Jun 28, 2016
mgedmin commented on pull request certbot/certbot#3213
@mgedmin

I'm mildly distressed by __repr__ inserting itself between __eq__ and __ne__, since those two maybe ought to go together.

Jun 28, 2016
mgedmin commented on pull request certbot/certbot#3213
@mgedmin

s/multiple files/multiple vhosts/

Jun 27, 2016
mgedmin commented on issue plone/buildout.coredev#139
@mgedmin

I'm fine with ZPL as a licence, and I expect the PF contrib agreement not to be any worse than the ZF one. (I've a commit bit for the Plone Collect…

Jun 27, 2016
mgedmin commented on pull request zopefoundation/ZConfig#4
@mgedmin

I did a git grep for <example> and didn't find any examples of example tags, including in the doc/ subdirectory ... shrug Never mind, it's not a pr…

Jun 23, 2016
mgedmin commented on pull request zopefoundation/ZConfig#4
@mgedmin

LGTM

Jun 23, 2016
mgedmin commented on pull request zopefoundation/ZConfig#4
@mgedmin

I'd love to see some examples of the <example> tag.

Jun 23, 2016
@mgedmin
Issue with upcoming release of SQLAlchemy 1.1
Jun 23, 2016
@mgedmin

0.7.7 is released.

Jun 23, 2016
Jun 23, 2016
@mgedmin
Jun 22, 2016
mgedmin commented on pull request zopefoundation/ZConfig#4
@mgedmin

I don't see any tests?

mgedmin deleted branch git-check-head-fix at mgedmin/ansible-modules-core
Jun 22, 2016
Jun 21, 2016
mgedmin commented on pull request wummel/linkchecker#662
@mgedmin

See also #650.

Jun 21, 2016
@mgedmin

FWIW wait_for: host=... timeout=300 is equivalent to time.sleep(300) if you don't provide a port (or path, or use state=drained): https://github.co…