New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker build #5

Closed
mgibeau opened this Issue Jan 3, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@mgibeau
Owner

mgibeau commented Jan 3, 2018

Currently works by using the bundled proxy in react-create-app's development environment. To create a proper Docker image, it should start an express server and serve the production build.

  • Express server to proxy API calls
  • Remove dependency on bundle proxy
  • Dockerfile
  • Pipeline for building and pushing to docker hub

@mgibeau mgibeau closed this in 4868f74 Jan 4, 2018

@mgibeau

This comment has been minimized.

Show comment
Hide comment
@mgibeau

mgibeau Jan 4, 2018

Owner

It turns out it wasn't necessary to remove the dependency, it's still useful for the development environment

Owner

mgibeau commented Jan 4, 2018

It turns out it wasn't necessary to remove the dependency, it's still useful for the development environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment