GH-55 Improve extension integration with PHPStan #71
Conversation
mglaman
force-pushed
the
gh55-improve-phpstan-integration
branch
from
9cd79ee
to
33261f4
Compare
|
I'm currently testing this branch with drupal upgrade_status. The first issue I run into is This is due to Changing it to a require_once works. The first run passed in my case, but continue to review+test with the |
|
Last comment + the branch would fix https://www.drupal.org/project/upgrade_status/issues/3057853 From my testing this looks good, with the minor change posted above. |
|
@attrib We should not need to require 🤔 or does this change the operation of the loaded autoloading files. |
| $builder->parameters['drupalServiceMap'][$serviceId] = $serviceDefinition; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| protected function camelize(string $id): string |
There was a problem hiding this comment.
This method is still used in loadConfiguration() (1/2 issues where travis complains)
There was a problem hiding this comment.
Code can stay removed, if the unreachable code above is removed.
|
|
||
| public function register(): void | ||
| private function registerServiceMap() |
There was a problem hiding this comment.
| private function registerServiceMap() | |
| private function registerServiceMap(): void |
Return typehint missing (2/2 where travis complains)
| @@ -95,6 +75,12 @@ public function loadConfiguration(): void | |||
| } | |||
| } | |||
| } | |||
| return; | |||
There was a problem hiding this comment.
Is this correct? It seems to work, but all code after this is unreachable.
There was a problem hiding this comment.
Got it now, code was moved to Bootstrap.php, code after return should be removed then.
Was this maybe added for drupal-check then? |
|
Refactoring this in #91 |
Fixes #55