Update phpstan/phpstan related dependencies to ^2.0"

[Boegie]

Naive first stab

[mglaman]

I'll probably want to open a 2.x branch as well. Thanks for trying at this.

[Boegie]

No worries, I'll chip away at this for an hour 2 from now.

[Boegie]

Ok, so this was more of a grind than actually Big Brain stuff.

I would recommend:

• Going over the identifiers that were (forcefully) added. There are a lot of them and they might not be consistent.
• The changes in .github/workflows/php.yml can be reverted when drupal core includes phpstan/phpstan:^2.0
• Replacing all @phpstan-ignore next-line nuke-em-all lines with the more targeted @phpstan-ignore [identifier] in a separate MR. I found some "hidden sins" whilst creating this MR.

Also:

A new branch might be a nice clean cut-off point to drop D9 support?

[mglaman]

oh, did rule identifiers become required, essentially fixing #803 😱 I wish I could have landed that sooner to reduce this effort. I appreciate it. I literally fell asleep at my laptop 2 times while working on that.

[mglaman]

I didn't review the commit log, but I'm guessing something about the format of the error identifier made PHPStan mad?

[Boegie]

Nope, this is a rare occasion where there was actually an identifier and I completely overlooked it.

Not too sure what to do now...

Do we want double-full-stop identifiers?

If we do I'll have to change the other identifiers in this class to the same prefix.

Help! :)

[mglaman]

I'm fine taking your changes, I was just curious

[mglaman]

A new branch might be a nice clean cut-off point to drop D9 support?

We can say 2.x drops Drupal 9 support, as a follow up to his PR.

[Boegie]

I appreciate it. I literally fell asleep at my laptop 2 times while working on that.

I couldn't handle in batches longer than one hour, extremely grindy stuff

[mglaman]

Thanks for this!!