Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make space between headings configurable #41

Closed
dvcrn opened this issue Jan 19, 2021 · 5 comments
Closed

Make space between headings configurable #41

dvcrn opened this issue Jan 19, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@dvcrn
Copy link

dvcrn commented Jan 19, 2021

Following markdown:

# Heading 1 
some test
# Heading 2

some text

### Some subheading

Some more text

Looks like this in preview:

Screen Shot 2021-01-19 at 17 22 48

The space between some of these headings is huge and makes the document harder to navigate/glance. It would be nice if this is configurable to make it a bit smaller, similar to how line-height is configurable

@mgmeyers
Copy link
Owner

Hey @dvcrn! Thanks for the suggestion.

One thing to note is that the padding sizes are relative to context and semantics—they come from http://matejlatin.github.io/Gutenberg/. So in your example you have two level 1 headings when in theory there should only be a single level 1 heading per page.

Semantics don't really matter, though, for personal knowledge management, so I'll definitely take your advice make this more flexible and configurable.

@mgmeyers mgmeyers added the enhancement New feature or request label Jan 28, 2021
@dvcrn
Copy link
Author

dvcrn commented Jan 29, 2021

That's a very good point, I didn't consider semantics

@iojw
Copy link

iojw commented Feb 14, 2021

+1 for this. It would be great if the spacing in preview could match the spacing in edit mode more closely because the fonts and styles between both of these modes are already similar except for this change in spacing.

@j-peeters
Copy link

j-peeters commented Feb 22, 2021

I would love a feature to define the space between headers and body text in your theme too.

@mgmeyers
Copy link
Owner

Hey all, I've made the heading sizes and margins configurable via the theme plugin. Please update the theme and the plugin, and let me know if your use case has been covered!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants