Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an editor panel that lets you edit, add, and delete server records. #44

Merged
merged 2 commits into from Feb 9, 2018

Conversation

@thomcc
Copy link
Collaborator

@thomcc thomcc commented Feb 2, 2018

We probably should have had this for a while, if I'm being honest.

Copy link
Owner

@mhammond mhammond left a comment

Do you think it's worth creating a new "module" for the editor? (and yeah, I wish "module" wasn't in scare quotes :)

@thomcc
Copy link
Collaborator Author

@thomcc thomcc commented Feb 5, 2018

Your call, if you'd like me to I can.

@mhammond
Copy link
Owner

@mhammond mhammond commented Feb 6, 2018

I think it makes sense. Can we make any of this stuff real modules yet?

@thomcc
Copy link
Collaborator Author

@thomcc thomcc commented Feb 8, 2018

I think it makes sense. Can we make any of this stuff real modules yet?

Not without breaking this on non-nightly, I think. It would be cool though, certainly.

@thomcc thomcc force-pushed the thomcc:record-editor branch from bf44ed6 to 3e6ff8d Feb 8, 2018
@mhammond mhammond merged commit 77c6489 into mhammond:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants