-
Notifications
You must be signed in to change notification settings - Fork 844
Generate help file during build rather than as a separate CI step #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
"but it worked on my machine!"... (and I tried to make sure to test from clean installs !) It's also annoyingly basically the same error as in #2392 |
…m/pywin32 into restore-shipping-help-file
…re-shipping-help-file
…re-shipping-help-file
…m/pywin32 into restore-shipping-help-file
…re-shipping-help-file
|
Hang on, help files are back in non-arm64 wheels since Python 309...
I'll update the scope of this PR and probably do a separate PR for the now-outdated doc. |
This generates and includes the help file in the setuptools build, rather than it being a separate CI-only step as before.
This has the advantage that pip installing from source should now always include the help file.
Since helpfiles have been restores, that also means that we should theorically be able to update the online doc from GitHub artifacts instead of downloading/installing from PyPI. (I think that'll require merging the workflow files though).