Mark Hammond
mhammond

  • Joined on May 13, 2009

Organizations

@mozilla
Aug 26, 2016
@mhammond
  • @thomcc d2e4c8b
    Various improvements to bookmark validator panel. (#12)
Aug 26, 2016
mhammond merged pull request mhammond/aboutsync#12
@mhammond
Various improvements to bookmark validator panel.
1 commit with 20 additions and 12 deletions
Aug 26, 2016
@mhammond
  • @thomcc 380349a
    Fix display of orphans in bookmark validation view (#11)
Aug 26, 2016
mhammond merged pull request mhammond/aboutsync#11
@mhammond
Fix display of orphans in bookmark validation view
1 commit with 14 additions and 3 deletions
Aug 23, 2016
@mhammond
  • @mhammond 1770666
    Fix 'yield yield' I added in my haste
Aug 23, 2016
@mhammond
  • @mhammond c351d8c
    Use the provider's bookmark tree when showing the client records tree.
Aug 22, 2016
@mhammond
Aug 20, 2016
@mhammond
  • @thomcc f7f427d
    Fix handling of non-object records in table inspector, and ensure the…
Aug 20, 2016
mhammond merged pull request mhammond/aboutsync#9
@mhammond
Fix handling of non-object records in table inspector, and ensure there's no flow content in "th"
1 commit with 19 additions and 12 deletions
Aug 12, 2016
@mhammond
  • @thomcc bd7bc59
    Preliminary integration of the addon validator (#8)
Aug 12, 2016
mhammond merged pull request mhammond/aboutsync#8
@mhammond
Preliminary integration of the addon validator
2 commits with 260 additions and 51 deletions
Aug 11, 2016
mhammond commented on pull request mhammond/aboutsync#8
@mhammond

This now conflicts, but I've no issue with merging this sooner rather than later, especially if it is changed such that it does something sane befo…

Aug 11, 2016
@mhammond
Aug 11, 2016
mhammond merged pull request mhammond/aboutsync#7
@mhammond
Fix react warnings
1 commit with 28 additions and 22 deletions
Aug 8, 2016
@mhammond

Sadly "uitour" seems too aggressive for reasons I don't understand (bug 1293181). When in that state, pretty-much all entry-points other than the h…

Jul 22, 2016
mhammond commented on pull request mozilla-services/tokenserver#93
@mhammond

Looks perfect!

Jul 22, 2016
@mhammond
Include the hashed fxa_uid in the tokenserver response body.
Jul 20, 2016
@mhammond

Yeah, agreed!

Jul 18, 2016
mhammond commented on pull request mozilla/fxa-content-server#3919
@mhammond

I can deal with this approach. I'd prefer to use "the one true way" universally, but not at the risk of introducing too many changes at once. Iter…

Jul 13, 2016
mhammond commented on pull request mozilla/fxa-content-server#3919
@mhammond

I think the general question we need to ask is "what happens when any of these config values is wrong or otherwise needs to change?" Let's say that…

Jul 13, 2016
mhammond commented on pull request mozilla/fxa-content-server#3919
@mhammond

would we know right away if there was an uptick in the number of Sync connection errors? No. This being wrong would be very bad. TPS would give us

Jul 12, 2016
mhammond commented on pull request mozilla/fxa-content-server#3919
@mhammond

Yeah, that SGTM - we could probably arrange for a different TPS instance to run against prod but only run one well-chosen (or new) individual test.

Jul 12, 2016
mhammond commented on pull request mozilla/fxa-content-server#3919
@mhammond

Yes, good point. I think we should make TPS use this each time it logs on, however, given we look like moving away from TPS running in prod, I'm no…

Jul 11, 2016
@mhammond

but I'm in favor of not upping the frequency of tickling that tiger without careful thought 😄 I'm a little more reckless than that - we know the …

Jul 8, 2016
mhammond commented on pull request mozilla/fxa-content-server#3919
@mhammond

and will only know that it broke via FF desktop The way I see this being implemented in desktop is that we will query this end-point at login tim…

Jul 8, 2016
@mhammond

(I think we saw this recently after a patch broke reupload.) FTR, the problem there was that we re-uploaded the commands we just processed withou…

Jul 7, 2016
@mhammond

Sorry I'm late to the party here - I'm not getting emails for this issue - hopefully this comment will fix that :) ISTM that many of these problems…

Jul 6, 2016
mhammond commented on issue mozilla/addons#156
@mhammond

Thanks for the reply, but I think that's misguided. What about the user who knows what they are looking for? they can search for specific add-ons …

Jul 6, 2016
@mhammond
Not able to search for addons via about:addons
Jul 4, 2016
@mhammond

I suspect fxaccounts:login will work, but it doesn't seem the right choice - there's a risk that parts of the system will assume this is a "first" …