improves GC, #22

mhausenblas · Feb 13, 2018 · 2b350d1 · 2b350d1
1 parent 004b9d8
commit 2b350d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/gc.go b/gc.go
@@ -6,11 +6,14 @@ import (
 )
 
 var (
-	gcPause             = 10 * time.Second
-	maxOrphanRuntimeSec = 20.0
+	// how often we check for orphans:
+	gcPause = 10 * time.Second
+	// how long a pod of a terminating dproc can run
+	// until we consider it an orphan (in seconds):
+	maxOrphanRuntimeSec = 30.0
 )
 
-func rmOrphanTerminatingDProcs() {
+func gcDProcs() {
 	for {
 		poNstart, err := kubectl(true, "get", "po",
 			"--selector=dproctype="+string(DProcTerminating), "-o=custom-columns=:metadata.name,:status.startTime", "--field-selector=status.phase=Running",

diff --git a/main.go b/main.go
@@ -120,6 +120,6 @@ func main() {
 	rwatch.init(currentenv().evt)
 	go rwatch.run()
 	// kick off garbage collection:
-	go rmOrphanTerminatingDProcs()
+	go gcDProcs()
 	interpreti(rl)
 }