This repository has been archived by the owner on Nov 8, 2020. It is now read-only.
Silex 2 and Pimple 3 compatibility (another one, with the minimal changes) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the share() method is not present anymore in Pimple 3 and functions are now shared by default. - the extend() method also auto reassign the key with the return value, so the `$app['key'] = ` assignment before is not needed anymore. - use new silex interface for bootable service - use a Pimple Container in the constructor of the service.
mheap
added a commit
that referenced
this pull request
Mar 6, 2015
Silex 2 and Pimple 3 compatibility (another one, with the minimal changes)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to use Silex 2.0-dev and Pimple 3 in silex-assetic.
$app['key'] =assignment before is not needed anymore.Hope it helps.