This repository has been archived by the owner on Apr 8, 2018. It is now read-only.
style() on HTML elements doesn't work in IE7 #105
Comments
I'm fine with this as long as it works in IE8 fine. Did you run the test suite? |
Yeah. I also added an example test for #103 which covers this case as well. |
Cool, can you create a pull request? |
Looks like #114 handles the styling setProperty case - there are a few cases of setProperty in transitions, and all removeProperty, that need to be wrapped in if checks as well. |
sun16
pushed a commit
to sun16/r2d3
that referenced
this issue
Feb 13, 2014
…tion, text calls on HTML elements
Resolved by pull request #139 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
http://jsfiddle.net/Cp52L/
The CSSStyleDeclaration shim (mentioned in #83) doesn't work for IE7. Thus r2d3 fails everywhere we call get/set/removeProperty (selection-style.js, transition-style.js). However, get/set/removeAttribute still works on the element.style objects just like IE8.
A proposed fix would be to replace all instances of get/set/removeProperty() with get/set/removeAttribute() respectively. BTW this would mean that the CSSStyleDeclaration shim isn't being used anymore.
The text was updated successfully, but these errors were encountered: