Skip to content
This repository has been archived by the owner on Apr 8, 2018. It is now read-only.

style() on HTML elements doesn't work in IE7 #105

Closed
sun16 opened this issue Jun 7, 2013 · 5 comments
Closed

style() on HTML elements doesn't work in IE7 #105

sun16 opened this issue Jun 7, 2013 · 5 comments

Comments

@sun16
Copy link
Collaborator

sun16 commented Jun 7, 2013

http://jsfiddle.net/Cp52L/

The CSSStyleDeclaration shim (mentioned in #83) doesn't work for IE7. Thus r2d3 fails everywhere we call get/set/removeProperty (selection-style.js, transition-style.js). However, get/set/removeAttribute still works on the element.style objects just like IE8.

A proposed fix would be to replace all instances of get/set/removeProperty() with get/set/removeAttribute() respectively. BTW this would mean that the CSSStyleDeclaration shim isn't being used anymore.

@mhemesath
Copy link
Owner

I'm fine with this as long as it works in IE8 fine. Did you run the test suite?

@sun16
Copy link
Collaborator Author

sun16 commented Jun 10, 2013

Yeah. I also added an example test for #103 which covers this case as well.
(see commit sun16@948f4f2)

@mhemesath
Copy link
Owner

Cool, can you create a pull request?

@sun16
Copy link
Collaborator Author

sun16 commented Feb 13, 2014

Looks like #114 handles the styling setProperty case - there are a few cases of setProperty in transitions, and all removeProperty, that need to be wrapped in if checks as well.

sun16 pushed a commit to sun16/r2d3 that referenced this issue Feb 13, 2014
sun16 added a commit that referenced this issue Feb 13, 2014
Fixes for #103, #105, #106 - style, transition, text calls on HTML elements
@sun16
Copy link
Collaborator Author

sun16 commented Feb 13, 2014

Resolved by pull request #139

@sun16 sun16 closed this as completed Feb 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants