Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the GEM compatible with Ruby < 2.3 #291

Closed
florrain opened this issue Jul 15, 2018 · 5 comments
Closed

Making the GEM compatible with Ruby < 2.3 #291

florrain opened this issue Jul 15, 2018 · 5 comments

Comments

@florrain
Copy link

Hey @mhenrixon

I would like to use the latest version in a Ruby 2.1 application. Loading the GEM with that version does not work because of the new safe navigation operator &. in the BaseLock class. There's also the use of the Integer#positive? that was added in 2.3 that makes the client middleware to explode.

I personally don't think helper methods should prevent the usage of your GEM, would you accept a PR to fix those? And enforcing the Ruby version in the gemspec to be >= 2?

If you know of other references to recent Ruby methods that I can add to that PR that would be helpful as well.

Thanks

@mhenrixon
Copy link
Owner

Please go ahead! You are so right in that the helper methods used shouldn’t prohibit the gem from being used.

Check the Sidekiq requirements though. I think in later Sidekiq versions 2.1 might not be usable.

@florrain
Copy link
Author

Great will have that PR up hopefully later today or early next week. Good idea, will double check on that 👍

@florrain
Copy link
Author

Another question for you -- do you have an estimated release date for the final v6?

@mhenrixon
Copy link
Owner

I was hoping to get some people to test it out first and check that everything is working ok. Any time someone suggests everything is working as advertised I'll cut a final v6.0.0.

The gem has been installed a few times now and since I haven't had that many complaints I'd say it is pretty fine for release.

@mhenrixon
Copy link
Owner

I'm closing this for now, ping me on gitter if you need any help with the Ruby 2.1 work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants