Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated chartkick.js and instructions #48

Merged
merged 1 commit into from Nov 16, 2019

Conversation

@ankane
Copy link
Collaborator

ankane commented Nov 10, 2019

Hey @mher, hope things are going well.

This PR updates chartkick.js to the latest version (released yesterday).

For the instructions:

  • Chart.js - updated version to match Ruby gem
  • Google Charts - switched to loader.js, which is required for Chartkick.js 3 (I missed this change as part of #47)
  • Highcharts - switched to https and jQuery not needed
@mher mher merged commit ec6a31c into mher:master Nov 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.