Add option to remove broker url from web UI #45

Closed
sylvinus opened this Issue Jan 5, 2013 · 5 comments

Projects

None yet

2 participants

@sylvinus
sylvinus commented Jan 5, 2013

In case the broker URL contains passwords to the database !

@sylvinus
sylvinus commented Jan 5, 2013

Same thing in the Broker tab for workers

@mher
Owner
mher commented Jan 10, 2013

Tried with redis and rabbitmq -- password in broker url is hidden. Which broker are you using?

@mher mher closed this Jan 19, 2013
@sylvinus
sylvinus commented Mar 2, 2013

I'm using rabbitmq, password was not hidden.

I had to apply the following patch to workers.html

69c69
<     <strong>Broker:</strong> {{ broker }}
---
>     <strong>Broker:</strong> -hidden-
@mher
Owner
mher commented Mar 3, 2013

Which version of Celery are you using? My tests show that Celery hides passwords:

import celery
app=celery.Celery(broker='amqp://foo:bar@example.com')
app.connection().as_uri()
'amqp://foo@example.com:5672//'

@sylvinus

Ok! The password is indeed hidden with latest Celery. However sometimes even exposing the username can be sensitive and an option would be welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment