Missing string functions + other fixes #35

florentpoujol · 2013-11-25T10:03:16Z

Hey

I added the missing string functions : find, format, gsub, gmatch and match.
All cases of pattern translation I encountered are working OK (yet there are probably many cases that won't).

I also fixed several other functions like ensure_arraymode(), pairs(), tonumber(), os.clock().

…_to_regex() in string.gsub()

…s replacement

…nction

…ttern) instead of the whole match

…ng (only partial support, several cases will not work)

…herever there is other characters than digits, dots or spaces in the input string (like Lua's tonumber() does)

…ing (again)

… in the pattern (like I did on november 9 with lua_gmatch_next() )

…ad of an array (no matter the arraymode property)

…tring.format()

…tern to call not_supported()

…n_to_regex()

…he captured chunks (if any)

…or one or more endChar before the first startChar

…t, fixed plain argument condition

…changed returned value of processMath()

…ted patterns in lua_pattern_to_regex()

florentpoujol · 2013-12-11T16:31:26Z

Resume of what I did since the last batch of commits :

Fixed all styles issues as reported (braces, inline var declaration, etc...). (note that lua_add, lua_substract & Co are doing some inline variable declaration).
Improved some patterns, made unsupported patterns to call not_supported()
Added very partial support for the %b pattern (it's supported when it's the only item in a pattern).
Fixed a lot of bugs in the string functions

The cases where I had table.arraymode set to true but table.uints as object is fixed. It was due to another technology (CraftStudio's web player) that would add arraymode itself, yet left table.uints as an object.

I am new to node.js and I couldn't find how to run the tests in the "tests" folder. Which is why I hadn't them included in the pull request yet. Can you explain ?

Thanks !

… value

…unction + updated tests

elisee · 2014-01-08T11:37:18Z

@florentpoujol looking at the package.json file, you should be able to run the tests with npm run test.

florentpoujol · 2014-01-08T14:36:36Z

@mherkender Hey, can you find time to review my latest commits ? Thanks !

florentpoujol · 2014-10-18T09:20:22Z

@mherkender
Maybe it's time to do something about these improvements ?

They have been used without issues in several of my projects.
The Travis CI build failed but apparently because of Node itself, not because a test failed.
So I am not sure what I can do from here...

florentpoujol added 30 commits Oct 21, 2013

Started adding string.find(), works without pattern

6064a12

Added string.gsub(), works without pattern

3d30cd7

Added luapattern_to_regex() and luareplacement_to_regex() functions

f7c0f42

Updated string.gsub() with patterns

f47b0dd

Added string.match() with patterns, is working

8f00b4f

Added missing replacements to luapattern_to_regex()

797937c

Fixed string.match()

dcdd1d5

Added patterns to string.find(), works OK

55ec5bd

Added use of check_string() in string.find(), gsub() and match()

bb5cbe5

Started adding string.gmatch() and lua_gmatch_next()

22e89c2

Fixed string.gmatch() and lua_gmatch_next(), works OK

05b3196

Began updating string.format(), will use sprintf() bu need fork

e4bc685

Fixed wrong index in string.find()

c16087f

Added sprintf.js-lua.js inside string.format()

0889cd1

Fixed some comments/indentation

7c62d3b

Fixed two bugs in string.format() and string.find()

d4e0ecb

Moved lua_gmatch_next() inside string.gmatch() + moved luareplacement…

f8cd838

…_to_regex() in string.gsub()

Fixed typo in os.clock()

595e9cc

Fixed exception message in sprintf.format

dd14521

Fixed a bug preventing arrays to be looped upon by pairs().

72b2ff2

Fixed yesterday's fix (allow some arrays to be looped by pairs())

7b9fb91

Fixed wrong behavior of string.gsub() + added support for functions a…

e4ab729

…s replacement

Added support for escaped special characters in luapattern_to_js() fu…

9c03024

…nction

lua_gmatch_next() now correctly returns the capture (if any in the pa…

74c1809

…ttern) instead of the whole match

Fixed string.gsub() when the pattern must match at the end of th stri…

19b309e

…ng (only partial support, several cases will not work)

Made tonumber() return null instead of NaN, and made it return null w…

1649096

…herever there is other characters than digits, dots or spaces in the input string (like Lua's tonumber() does)

Fixed string.gsub() when the pattern must match at the end of the str…

65c9443

…ing (again)

Made string.match() return the correct match when there was a capture…

9abe406

… in the pattern (like I did on november 9 with lua_gmatch_next() )

Prevented an error in tonumber() if e argument was not of type string

250f6a5

Made ensure_arraymode() also work when table.uints is an object inste…

Loading status checks…

18fe311

…ad of an array (no matter the arraymode property)

florentpoujol added 4 commits Dec 3, 2013

Fixed equality checks in string.gmatch() and string.match()

b6ccb1d

Added support for g and G format in string.format()

99eed03

Fixed wrong behavior of o, x and X formats with negatives values in s…

90e5c34

…tring.format()

Improved %p pattern in lua_pattern_to_regex(), made not supported pat…

5759c6f

…tern to call not_supported()

stuta mentioned this pull request Dec 5, 2013

Small bugs when parsing code gamesys/moonshine#1

Closed

florentpoujol added 16 commits Dec 9, 2013

Improved regexes to detect use of the hyphen quantifier in lua_patter…

a8be65d

…n_to_regex()

Added get_balanced_match() function + use in string.find()

40a581d

Made patterns not composed only of one balanced pattern unsupported

69bc575

Added support for balanced match in string.gsub()

8dd9bca

Added support for balanced match in string.match()

4b3889e

Improved string.find() : now returns the correct indexes as well as t…

7ccdc68

…he captured chunks (if any)

Fixed get_balanced_match() when there is more startChar than endChar …

1cae6c7

…or one or more endChar before the first startChar

Added support for balanced match in string.gmatch()

24ee541

Made capture index in patterns not supported

7d8b1d4

Improved string.find() : added use of lua_tonumber() on index argumen…

81e9644

…t, fixed plain argument condition

Fixed missing bit in string.gmatch()

a98bde5

Improved string.gsub() : added use of lua_tonumber() fo n argument + …

6f684d4

…changed returned value of processMath()

Added use of lua_tonumber() in string.byte(), match(), rep() and sub()

f27c12b

Removed "character classes between square brackets" from the unsuppor…

809fccc

…ted patterns in lua_pattern_to_regex()

Fixed returned value when string.find() don't find anything

94757a7

Fixed a wrong indentation

Loading status checks…

6a75a5d

florentpoujol added 5 commits Dec 27, 2013

Fixed string.byte()

Loading status checks…

921c62b

Fixed while() condition in string.byte()

Loading status checks…

48557e9

Added tests for string functions

e8278ef

Fixed string.gsub() when the replacement is a function that returns a…

Loading status checks…

b3e10f2

… value

string.gsub() now passes the correct argument(s) to the replacement f…

Loading status checks…

3013379

…unction + updated tests

mherkender / lua.js

Missing string functions + other fixes #35

Missing string functions + other fixes #35

florentpoujol commented Nov 25, 2013

florentpoujol commented Dec 11, 2013

elisee commented Jan 8, 2014

florentpoujol commented Jan 8, 2014

florentpoujol commented Oct 18, 2014

mherkender / lua.js

Missing string functions + other fixes #35

Missing string functions + other fixes #35

Conversation

florentpoujol commented Nov 25, 2013

florentpoujol commented Dec 11, 2013

elisee commented Jan 8, 2014

florentpoujol commented Jan 8, 2014

florentpoujol commented Oct 18, 2014