Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #15

Merged
merged 7 commits into from
Aug 13, 2020
Merged

Add CI #15

merged 7 commits into from
Aug 13, 2020

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Aug 7, 2020

Run tests on CI

@inverse inverse mentioned this pull request Aug 7, 2020
@mherrmann
Copy link
Owner

Looks great. Instead of pytest, could we just use python -m unittest?

@inverse
Copy link
Contributor Author

inverse commented Aug 10, 2020

@mherrmann Why do you prefer unittest over pytest? I've mainly only used pytest And like the way it can integrate other plugins for generating coverage at the same time etc.

@mherrmann
Copy link
Owner

@inverse I like to have as few additional dependencies as possible. python -m unittest does the job just fine.

@inverse
Copy link
Contributor Author

inverse commented Aug 12, 2020

The dependencies are defined in requirements-test and not a hard dependency of the package though.

I like the additional reporting of deprecated code that it brings. Does unittest provide that?

@inverse
Copy link
Contributor Author

inverse commented Aug 12, 2020

@mherrmann I stand corrected - unittest does also yield deprecated warnings.

Okays - I'll revert the changes - we can always add it back.

@mherrmann mherrmann merged commit 1727ba9 into mherrmann:master Aug 13, 2020
@mherrmann
Copy link
Owner

Thanks!

@inverse inverse deleted the add-ci branch August 13, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants