Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Windows] only runs one spec file from spec folder #138

Closed
mpareja opened this Issue Mar 5, 2012 · 4 comments

Comments

Projects
None yet
3 participants

mpareja commented Mar 5, 2012

Reproduction

  • create a spec file with a test in it and put it inside a directory named 'spec'
  • copy that spec file into the same 'spec' directory but change the name
  • run: jasmine-node spec

It only sees one test. From what I've seen, it looks like it only runs the tests from one of the files in the spec directory instead of all specs.

Contributor

kybernetikos commented Mar 30, 2012

The reason for this is that findit (which is used by jasmine-node to recurse over directory trees) will only ever process one file on windows because node reports that every file has an inode of 0. One possible fix is to use a different library that doesn't do that check when given files with an inode of 0. I've submitted a pull request #141 which uses walkdir which doesn't have this problem.

mpareja commented Mar 30, 2012

@kybernetikos At the moment I've just been patching the version of findit that gets installed with Jasmine. It would be nice to switch off of findit to have this resolved (and since findit seems to be unmaintained).

CodingFabian added a commit to CodingFabian/jasmine-node that referenced this issue Apr 10, 2012

Already fixed with pull request #141.

@mpareja mpareja closed this Apr 10, 2012

mpareja commented Apr 10, 2012

Confirmed using walker has fixed this on Windows 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment