Restored growl reporter. #296

Merged
merged 1 commit into from Mar 7, 2014

Projects

None yet

2 participants

@AlphaHydrae
Contributor

Restoring my growl reporter which I upgraded to be compatible with Jasmine 2.0.

Run node lib/jasmine-node/cli.js --growl spec to see it work.

Sorry for the double pull request. I picked the wrong branch earlier.

@AlphaHydrae AlphaHydrae referenced this pull request in AlphaHydrae/jasmine-growl-reporter Mar 6, 2014
Closed

Jasmine-Node 2.0.0 Support #1

@AlphaHydrae
Contributor

Since it looks like you're in the process of setting up new coffeescript files right now. I'll fix this tomorrow.

@tebriel
Contributor
tebriel commented Mar 6, 2014

Yeah, sorry, went full-refactor on the repo. WIll make sure that growl is in place, just commented out.

@tebriel
Contributor
tebriel commented Mar 6, 2014

You should be solid now. I'm done for the day. Sorry for the high volatility.

@AlphaHydrae
Contributor

No problem. Should be good now.

@tebriel
Contributor
tebriel commented Mar 7, 2014

I messed it up again, I just resolved the conflicts, they weren't bad.

@tebriel tebriel merged commit 23e1594 into mhevery:Jasmine2.0 Mar 7, 2014
@tebriel
Contributor
tebriel commented Mar 7, 2014

Very nice! Took me a minute to remember I had to reinstall the terminal reporter, 'cause that was missing (guess it got lost when I clean-installed) but now I'm good.

@AlphaHydrae
Contributor

Excellent! Thanks for the help.

@AlphaHydrae AlphaHydrae deleted the AlphaHydrae:growl-reporter-upgrade branch Mar 7, 2014
@tebriel
Contributor
tebriel commented Mar 7, 2014

NP. Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment