Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Change tab initialize from array to hash #7

Merged
merged 1 commit into from

4 participants

@krasnoukhov
Collaborator

No description provided.

@krasnoukhov
Collaborator

Also there are problem with assets i didn't fix.

@bnorton

This is what I need.

However @krasnoukhov you have not run your tests locally and therefore the version bump in Sidekiq caused a spec failure. Please fix..

@krasnoukhov
Collaborator
@bnorton
@krasnoukhov
Collaborator

Ok, i've removed Sidekiq version bump.
Related discussion: mperham/sidekiq#481

@jakedahn

+1, plz merge this - im using it in my own branch right now but would be nice to have it in the actual gem.

@mhfs mhfs merged commit db1f7d5 into mhfs:master

1 check failed

Details default The Travis build failed
@mhfs
Owner

hi guys, I merged and also made it compatible with both post and pre 2.5 web extension api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 31, 2012
  1. @krasnoukhov
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  lib/sidekiq/failures.rb
  2. +1 −1  lib/sidekiq/failures/version.rb
View
2  lib/sidekiq/failures.rb
@@ -10,7 +10,7 @@ module Failures
end
Sidekiq::Web.register Sidekiq::Failures::WebExtension
-Sidekiq::Web.tabs << "Failures"
+Sidekiq::Web.tabs["Failures"] = "failures"
Sidekiq.server_middleware do |chain|
chain.add Sidekiq::Failures::Middleware
View
2  lib/sidekiq/failures/version.rb
@@ -1,5 +1,5 @@
module Sidekiq
module Failures
- VERSION = "0.0.2"
+ VERSION = "0.0.3"
end
end
Something went wrong with that request. Please try again.