Change tab initialize from array to hash #7

Merged
merged 1 commit into from Nov 1, 2012

Projects

None yet

4 participants

@krasnoukhov
Collaborator

No description provided.

@krasnoukhov
Collaborator

Also there are problem with assets i didn't fix.

@bnorton
Contributor
bnorton commented Oct 31, 2012

This is what I need.

However @krasnoukhov you have not run your tests locally and therefore the version bump in Sidekiq caused a spec failure. Please fix..

@krasnoukhov
Collaborator

I've planned to fix assets issue in this pull request, but now don't know
how exactly. Any suggestions on this?

Dmitry Krasnoukhov
Developer at Unteleported
+38 (066) 126-02-22
dmitry@krasnoukhov.com
http://krasnoukhov.com

@bnorton
Contributor
bnorton commented Oct 31, 2012

I'm not sure if that's in the scope of this pull request to be fair.

On Wednesday, October 31, 2012, Dmitry Krasnoukhov wrote:

I've planned to fix assets issue in this pull request, but now don't know
how exactly. Any suggestions on this?

Dmitry Krasnoukhov
Developer at Unteleported
+38 (066) 126-02-22
dmitry@krasnoukhov.com <javascript:_e({}, 'cvml',
'dmitry@krasnoukhov.com');>
http://krasnoukhov.com


Reply to this email directly or view it on GitHubhttps://github.com/mhfs/sidekiq-failures/pull/7#issuecomment-9950106.

@krasnoukhov
Collaborator

Ok, i've removed Sidekiq version bump.
Related discussion: mperham/sidekiq#481

@jakedahn
jakedahn commented Nov 1, 2012

+1, plz merge this - im using it in my own branch right now but would be nice to have it in the actual gem.

@mhfs mhfs merged commit db1f7d5 into mhfs:master Nov 1, 2012

1 check failed

default The Travis build failed
Details
@mhfs
Owner
mhfs commented Nov 1, 2012

hi guys, I merged and also made it compatible with both post and pre 2.5 web extension api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment