From 1b5a32380e64aa3e2bac78ebbd3fae414d3948a1 Mon Sep 17 00:00:00 2001 From: Morgan Brown Date: Mon, 9 Jan 2012 11:09:17 -0800 Subject: [PATCH] Only log cache write if the operation was successful Signed-off-by: David Souza --- lib/cached_resource/caching.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/cached_resource/caching.rb b/lib/cached_resource/caching.rb index 8b30742..29fc3e6 100644 --- a/lib/cached_resource/caching.rb +++ b/lib/cached_resource/caching.rb @@ -64,11 +64,12 @@ def cache_read(key) # The key is processed to make sure it is valid. def cache_write(key, object) key = cache_key(Array(key)) unless key.is_a? String - cached_resource.logger.info("#{CachedResource::Configuration::LOGGER_PREFIX} WRITE #{key}") - cached_resource.cache.write(key, object, :expires_in => cached_resource.ttl) + result = cached_resource.cache.write(key, object, :expires_in => cached_resource.ttl) + result && cached_resource.logger.info("#{CachedResource::Configuration::LOGGER_PREFIX} WRITE #{key}") + result end - # generate the request cache key + # Generate the request cache key. def cache_key(*arguments) "#{name.parameterize.gsub("-", "/")}/#{arguments.join('/')}".downcase end