Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold diffs by default #268

Closed
spar01 opened this issue Aug 3, 2018 · 3 comments
Closed

Fold diffs by default #268

spar01 opened this issue Aug 3, 2018 · 3 comments

Comments

@spar01
Copy link
Contributor

spar01 commented Aug 3, 2018

Currently on invoking :SignigyDiff, the fold on the edited version of the file are opened whereas the folds on the original version are closed. This seems a little inconsistent to me. Do you think it would make sense to fold both? That would make it easier to follow the diffs as well. Users can then use 'za' to toggle the folds if needed.

@spar01
Copy link
Contributor Author

spar01 commented Aug 4, 2018

I tried this by removing the foldopen command in the diffmode function. Seems to work well.

I am not sure what the intent of the folding behaviour was originally, but if not by default then maybe could you consider adding this as a user configurable option?

Let me know if you think this is something you want to add and I can create a PR 😀

@mhinz
Copy link
Owner

mhinz commented Aug 4, 2018

Hmm, you're right. It never bothered me, but I agree that it's probably not expected.

Please send a PR!

@spar01
Copy link
Contributor Author

spar01 commented Aug 5, 2018

Created PR #269

@mhinz mhinz closed this as completed in 40d1a4e Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants