Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing quotes and delimiter in quoted field throws an error #67

Closed
ygra opened this issue Jul 17, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@ygra
Copy link

commented Jul 17, 2014

I tested with a field like this:

""","""

which should be parsed as

","

Because it's a quoted field, that means "" will become " and the delimiter is a legal character. However, I get »Unexpected quotes« and parsing stops.

(Testing a little more, a minimal example seems to be

","""

That is, an escaped quote, following a delimiter, within a quoted field. Putting the quote before the delimiter works as expected.)

@mholt mholt added under review and removed under review labels Jul 17, 2014

@mholt

This comment has been minimized.

Copy link
Owner

commented Jul 17, 2014

Great find. I confirmed this and added a test. Changing line 1066 makes it work:

return (!_inQuotes && isBoundary(_i-1)) || isBoundary(_i+1);

Thanks for the report!

@mholt mholt closed this in e291344 Jul 17, 2014

@mholt mholt added this to the 3.1 milestone Sep 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.