Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File streaming and multi-threading not working in Firefox #76

Closed
wikkiewikkie opened this issue Aug 8, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@wikkiewikkie
Copy link

commented Aug 8, 2014

When trying to stream a file using a worker, Firefox throws:

ReferenceError: FileReader is not defined (Line 554)

This seems to be related to only FileReaderSync being supported in Firefox web workers. See
http://stackoverflow.com/questions/22741478/firefox-filereader-is-not-defined-only-when-called-from-web-worker

Also confirmed it is not working on the demo page. Tested using FF 30.0

@mholt

This comment has been minimized.

Copy link
Owner

commented Aug 8, 2014

Hm, that's annoying. See this: http://stackoverflow.com/questions/24708649/why-does-web-worker-performance-sharply-decline-after-30-seconds

Though Firefox does not seem to suffer from the performance malady as badly as Chrome, it still slowed down dramatically after about 45 seconds which is why I just went the async route.

Before I start complaining about Firefox's quirks here, I'll just go look into a fix instead. 😕 Thanks for the report!

@mholt mholt closed this in 553f5d7 Aug 9, 2014

@mholt

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2014

@wikkiewikkie That should do the trick. Performance may not be awesome, but at least it won't error out. Let me know if it gives you any trouble!

PS. For what it's worth, I've filed a bug with Mozilla to see if they'll consider adding FileReader: https://bugzilla.mozilla.org/show_bug.cgi?id=1051150

@mholt mholt added the confirmed bug label Aug 9, 2014

@mholt

This comment has been minimized.

Copy link
Owner

commented Aug 16, 2014

Well, it looks like the fine folks at Mozilla are already on it (I couldn't even find an earlier bug report for the same thing until they linked to one) and I imagine this will roll out within the next couple versions of Firefox. Now the question is, after that happens, when can we drop support for the older versions of Firefox in order to clean up some of this mess? :)

@mholt mholt removed the confirmed bug label Aug 28, 2014

@mholt mholt modified the milestone: 3.1 Sep 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.