Added LZ4 compression #24

merged 3 commits into from Feb 15, 2017


None yet

3 participants


No description provided.

railsmechanic added some commits Feb 15, 2017
@railsmechanic railsmechanic Added Tar.LZ4 compression
Added Tar.LZ4 compression
@railsmechanic railsmechanic Update
@railsmechanic railsmechanic Updated comments
@railsmechanic railsmechanic referenced this pull request Feb 15, 2017

Added LZ4 compression #23

@mholt mholt merged commit 0094834 into mholt:master Feb 15, 2017

3 checks passed

ci/gopherci Found no issues \ʕ◔ϖ◔ʔ/
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
mholt commented Feb 15, 2017

Cool, thanks for your contribution!

@@ -74,7 +74,7 @@ func symmetricTest(t *testing.T, name string, ar Archiver) {
if info.IsDir() {
// stat dir instead of read file
- _, err := os.Stat(origPath)
+ _, err = os.Stat(origPath)
shurcooL Feb 15, 2017 edited Contributor

Just a nitpicky question out of curiosity @railsmechanic, what was the motivation/rationale behind this change?

railsmechanic Feb 15, 2017 Collaborator

My IDE indicates that this err is shadowed by the definition at line 70. 😬

mholt Feb 15, 2017 edited Owner

I noticed this with your PR, but it looks harmless in this case.

railsmechanic Feb 15, 2017 edited Collaborator

Absolutely! A harmless change to stop Atom complaining about a shadowed variable. 😄

shurcooL Feb 15, 2017 Contributor

I see, thanks.

I would want to discuss whether a shadowed variable with name err and type error is something that warrants issuing warnings about, but that's a discussion to have elsewhere.

mholt Feb 15, 2017 Owner

I think it depends largely on the context. That might be why go vet doesn't issue warnings about it...

railsmechanic Feb 15, 2017 Collaborator

It's great being a software developer, where a single colon is a starting point for a conversation. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment