Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch zip handling to use #273

merged 2 commits into from Dec 23, 2020

Switch zip handling to use #273

merged 2 commits into from Dec 23, 2020


Copy link

@Jacalz Jacalz commented Dec 23, 2020

This improves the performance over the stdlib implementation.
Archiving seems to be about 2.5x faster in my tests and archiving seems to be around 1.2x faster.
Those numbers should be even better after #272 is merged with the updated of the compression library.

Copy link

mholt commented Dec 23, 2020

Thanks, this is a good idea. I think when I wrote this package, the upstream wasn't quite there yet. But I think we use it in Caddy now too so I approve.

Make sure go.mod/go.sum are updated accordingly if necessary!

Copy link
Contributor Author

Jacalz commented Dec 23, 2020

This worked good even without the updating, so I just figured that I would separate the two. This should be ready as is :)

@mholt mholt merged commit 699ca56 into mholt:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants