Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plain .gz and .bz2 files #81

Merged
merged 4 commits into from
Nov 7, 2018

Conversation

justone
Copy link
Contributor

@justone justone commented Sep 2, 2018

Here's my first attempt at supporting plain gzip and bzip2 files.

Please let me know what you think.

Thank you.

Closes #80

* added file content detection for gz and bzip
* add test support for single file archives
@johnarok johnarok self-requested a review September 12, 2018 00:31
@mholt
Copy link
Owner

mholt commented Nov 7, 2018

Hey @justone -- thanks for your contribution. I'm sorry I didn't look at it sooner, but the truth is I was really busy working on a software project that actually relies heavily on archiver under the hood and since then I've discovered a number of design flaws in the package from when I first wrote it years ago (see #90) - and so I've spent a few days and marathoned a rewrite of the whole thing (#99).

Mostly from scratch.

However, I was inspired by the issue and by your change, so what's going to happen is I will merge in this PR so you get credit in the commit history, before I wipe out the current archiver package with my overhaul in #99. It was just easier this way.

@justone
Copy link
Contributor Author

justone commented Nov 7, 2018

Hey @mholt,

Sounds great. Thanks for such a useful library. I look forward to integrating the new version.

Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort!

@mholt mholt merged commit 40725de into mholt:master Nov 7, 2018
mholt pushed a commit that referenced this pull request Nov 7, 2018
* Add support for plain .gz and .bz2 files

Closes #80

* fix tests for single file archives

* added file content detection for gz and bzip
* add test support for single file archives

* fix bzip2 source filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants