Updated tar archiver to create directories similar to zip archiver #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weingart
reviewed
Sep 10, 2018
| } | ||
|
|
||
| if baseDir != "" { | ||
| header.Name = filepath.ToSlash(filepath.Join(baseDir, strings.TrimPrefix(path, source))) | ||
| name, err := filepath.Rel(source, fpath) |
There was a problem hiding this comment.
Any chance you can add a test for this here, that fails without this diff, and passes with this diff?
|
This might not be an issue anymore with #99. Will probably close this if there's no more activity or unless someone confirms it's still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: patch
Bug Fix
I noticed that when I create tar files, the output directory structure has nesting that is not intended. I then tested the zip archiver and saw that this was not an issue. I updated the tar archiver to have same directory parsing logic as zip.
Changes