Added additional '-' to common log format #1398 #1399

merged 2 commits into from Feb 4, 2017


None yet

2 participants

tobya commented Feb 4, 2017

A very simple fix for #1398 by simply adding a second '-' into the format for common log file.

In the future it may be desirable to add a placeholder for {>User} or {user} to "represent userid of the person requesting the document as determined by HTTP authentication" , however my personal opinion may be that in 2016 HTTP authentication even with HTTPS is not sufficiently 'common'.

This simple fix makes the caddy common file format compatible with the generally accepted 'common' file format, even if it will never provide the 'user' in the log.

tobya added some commits Feb 4, 2017
@tobya tobya Added additional - to common log file format
@tobya tobya Merge branch 'master' into issue1398
mholt approved these changes Feb 4, 2017 View changes

Since we don't have a placeholder for the HTTP auth user at this time (although I think we could/should add one), this is fine. Thanks!

@mholt mholt merged commit 9e9298e into master Feb 4, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
licence/cla Contributor License Agreement is signed.
@mholt mholt deleted the issue1398 branch Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment