Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global FallbackHosts for vhost matching #1781

Merged
merged 1 commit into from Jul 26, 2017
Merged

Conversation

sergeyfrolov
Copy link
Member

1. What does this change do, exactly?

Adds global FallbackHosts for vhost matching instead of hardcoded values.
Makes it possible for plugins and directives to change the list of FallbackHosts.

2. Please link to the relevant issues.

None

3. Which documentation changes (if any) need to be made because of this PR?

None

4. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I am willing to help maintain this change if there are issues with it later

@sergeyfrolov sergeyfrolov requested a review from mholt July 25, 2017 20:13
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Sergey!

@mholt mholt merged commit 4991d70 into master Jul 26, 2017
@mholt mholt deleted the global-fallback-hosts branch July 26, 2017 01:55
@mholt mholt modified the milestone: 0.10.5 Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants