instance restart (reload) event #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mholt
reviewed
May 24, 2018
plugins.go
Outdated
| ShutdownEvent = "shutdown" | ||
| CertRenewEvent = "certrenew" | ||
| InstanceStartupEvent = "instancestartup" | ||
| InstanceRestart = "restart" |
There was a problem hiding this comment.
Can we make the string consistent with the name? "instancerestart"?
lbguilherme
reviewed
May 24, 2018
plugins.go
Outdated
| ShutdownEvent = "shutdown" | ||
| CertRenewEvent = "certrenew" | ||
| InstanceStartupEvent = "instancestartup" | ||
| InstanceRestart = "instancerestart" |
There was a problem hiding this comment.
Maybe it also should be InstanceRestartEvent for consistency
sigtrap_posix.go
Outdated
| @@ -90,6 +90,7 @@ func trapSignalsPosix() { | |||
| purgeEventHooks() | |||
|
|
|||
| // Kick off the restart; our work is done | |||
| EmitEvent(InstanceRestart, nil) | |||
There was a problem hiding this comment.
You missed this one 😛 needs to be InstanceRestartEvent too
theodesp
approved these changes
Jun 12, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this change do, exactly?
New event type called restart added which is emitted at server restart (at SIGUSR1)
2. Please link to the relevant issues.
We are using caddy as embedded server and we need to make preparations before restarts
3. Which documentation changes (if any) need to be made because of this PR?
Nothing
4. Checklist