Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Don't disconnect loadFinished in UnsupportedContentHandler

WebPage::setContent will cause the loadFinished signal to fire, so
there's no need to call loadFinished if the signal is connected.
  • Loading branch information...
commit 2eb38b3c0235de382a754ac8d3a0d71ed7704fdf 1 parent b28452e
Matthew Horan authored December 05, 2012

Showing 1 changed file with 0 additions and 3 deletions. Show diff stats Hide diff stats

  1. 3  src/UnsupportedContentHandler.cpp
3  src/UnsupportedContentHandler.cpp
@@ -11,16 +11,13 @@ void UnsupportedContentHandler::renderNonHtmlContent() {
11 11
   QByteArray text = m_reply->readAll();
12 12
   m_page->mainFrame()->setContent(text, QString("text/plain"), m_reply->url());
13 13
   m_page->unsupportedContentFinishedReply(m_reply);
14  
-  m_page->loadFinished(true);
15 14
   this->deleteLater();
16 15
 }
17 16
 
18 17
 void UnsupportedContentHandler::waitForReplyToFinish() {
19 18
   connect(m_reply, SIGNAL(finished()), this, SLOT(replyFinished()));
20  
-  disconnect(m_page, SIGNAL(loadFinished(bool)), m_page, SLOT(loadFinished(bool)));
21 19
 }
22 20
 
23 21
 void UnsupportedContentHandler::replyFinished() {
24 22
   renderNonHtmlContent();
25  
-  connect(m_page, SIGNAL(loadFinished(bool)), m_page, SLOT(loadFinished(bool)));
26 23
 }

0 notes on commit 2eb38b3

Please sign in to comment.
Something went wrong with that request. Please try again.