Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static website sharing with OnionShare #791

Closed
hiromipaw opened this issue Sep 25, 2018 · 5 comments
Closed

Static website sharing with OnionShare #791

hiromipaw opened this issue Sep 25, 2018 · 5 comments
Milestone

Comments

@hiromipaw
Copy link
Collaborator

@hiromipaw hiromipaw commented Sep 25, 2018

With @holantonela have been thinking of how OnionShare could be used to share a static website.

I have started to hack this functionality for the cli.

https://github.com/hiromipaw/onionshare/tree/website-sharing

Please consider that there are still quite a few things to clean up and a few consideration to make, but since I believe there isn't better explanation of a feature than a few lines of code, I thought this could be a nice way to start a conversation about this.

Please let me know what you all think.

@micahflee
Copy link
Owner

@micahflee micahflee commented Sep 27, 2018

Nice this is awesome! I just tested it out and it appears to partially work! :) I'm super excited for this feature, and also I'd love to help develop it with you too.

We have a bunch to finish with OnionShare 2.0, including a lot of localization work. Since this is a major new feature, I think maybe we can aim for version 2.1.

@micahflee micahflee added this to the 2.1 milestone Sep 30, 2018
@hiromipaw
Copy link
Collaborator Author

@hiromipaw hiromipaw commented Oct 8, 2018

Hi, so a few more updates :)
I didn't like to use the send_from_directory directive, so I am now reading the html file and rendering as safe text. Not sure yet I like this. But it can be sanitize too (which wasn't possible when reading a single file).
Also I have included some more logic so that a static website can have relative paths. Should refine this still in case the page name isn't index.html.
Some more cleanup needed.

@subscriptionblocker
Copy link

@subscriptionblocker subscriptionblocker commented Feb 21, 2019

With @holantonela have been thinking of how OnionShare could be used to share a static website.

I have started to hack this functionality for the cli.

https://github.com/hiromipaw/onionshare/tree/website-sharing

Please consider that there are still quite a few things to clean up and a few consideration to make, but since I believe there isn't better explanation of a feature than a few lines of code, I thought this could be a nice way to start a conversation about this.

Please let me know what you all think.

I've been requesting this feature for a long time. Am baffled that your small group can deliver so much and the Tor group so little?

If possible would like to home host multiple static websites with onionshare. V3 with authorization cookies.

@micahflee micahflee removed this from the 2.1 milestone Apr 19, 2019
@micahflee micahflee added this to the 2.2 milestone Apr 19, 2019
@mig5 mig5 mentioned this issue May 10, 2019
@micahflee
Copy link
Owner

@micahflee micahflee commented May 24, 2019

I'm keeping this issue open until #990, #991, #992, #993, and #994 are resolved.

@micahflee
Copy link
Owner

@micahflee micahflee commented Sep 15, 2019

#992 and #994 still need to be resolved, but I think it's fine to close this now.

@micahflee micahflee closed this Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants