add promise_complete? method

michaeljbishop · Nov 1, 2012 · 8bf696d · 8bf696d
1 parent e768ae7
commit 8bf696d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/rake/thread_pool.rb b/lib/rake/thread_pool.rb
@@ -40,7 +40,7 @@ def future(*args,&block)
 
       promise_core = lambda do
         # can't execute more than once
-        next unless promise_result.equal?(NOT_SET) && promise_error.equal?(NOT_SET)
+        next if promise_complete?(promise_result, promise_error)
         stat :promise_will_execute, :item_id => promise_worker.object_id
         begin
           promise_result = block.call(*local_args)
@@ -83,6 +83,11 @@ def promise.value
       promise
     end
 
+    def promise_complete?(promise_result, promise_error)
+      ! promise_result.equal?(NOT_SET) ||
+        ! promise_error.equal?(NOT_SET)
+    end
+
     # Waits until the queue of futures is empty and all threads have exited.
     def join
       @threads_mon.synchronize do