New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breathe on windows fails due to missing path to doxygen #271

Closed
psifertex opened this Issue Jul 28, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@psifertex
Contributor

psifertex commented Jul 28, 2016

Breathe/sphinx/doxygen on Windows (at least under a Jenkins build environment) fails to run because https://github.com/michaeljones/breathe/blob/master/breathe/process.py#L87 does not find doxygen in the path without an additionalshell=True option to the subprocess call. The change that worked for me was:

        self.run_process(['doxygen', cfgfile], cwd=build_dir, shell=True)

Note that shell=True is considered a potential security risk, however in this case all arguments to the command-line are from local data and so it shouldn't be a concern.

@vitaut

This comment has been minimized.

Show comment
Hide comment
@vitaut

vitaut Jul 28, 2016

Collaborator

Thanks for catching this. Could you submit a PR?

Collaborator

vitaut commented Jul 28, 2016

Thanks for catching this. Could you submit a PR?

psifertex added a commit to psifertex/breathe that referenced this issue Sep 18, 2016

Fix for #271
Windows requires the shell true option for the path to work.
@psifertex

This comment has been minimized.

Show comment
Hide comment
@psifertex

psifertex Sep 18, 2016

Contributor

Certainly -- just did so, sorry, I missed this reply originally.

Contributor

psifertex commented Sep 18, 2016

Certainly -- just did so, sorry, I missed this reply originally.

@michaeljones

This comment has been minimized.

Show comment
Hide comment
@michaeljones

michaeljones Sep 30, 2016

Owner

Should be fixed in with #277

Owner

michaeljones commented Sep 30, 2016

Should be fixed in with #277

melvinvermeeren pushed a commit that referenced this issue Jun 4, 2018

Fix for #271
Windows requires the shell true option for the path to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment