Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removed dependency on rspec mode by redefining reature-root-directory-p #11

Merged
merged 1 commit into from May 31, 2011

Conversation

Projects
None yet
2 participants
Contributor

pchristensen commented May 31, 2011

All of the commands were failing when I tried to use feature-mode because I didn't have rspec mode installed. It didn't seem like a meaningful dependency (it was a one-liner change) so I thought this could make feature-mode more self-contained.

michaelklishin added a commit that referenced this pull request May 31, 2011

Merge pull request #11 from pchristensen/remove_rspec_dependency
Removed dependency on rspec mode by redefining reature-root-directory-p

@michaelklishin michaelklishin merged commit 7af0731 into michaelklishin:master May 31, 2011

Owner

michaelklishin commented May 31, 2011

Thank you. Not that I consider RSpec mode dependency a big deal but those who want to use both cucumber.el and rspec-mode will still be able to do it.

Contributor

pchristensen commented May 31, 2011

Sure, I had no problem with rspec being referenced. Like you say, lots of overlap between users of the two modes. It just seemed too easy to replace.

BTW, the very next thing I did after submitting this was to setup rspec-mode :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment