URI-based configuration should be publicly accessible #9

Closed
charles-dyfis-net opened this Issue Aug 15, 2012 · 5 comments

Projects

None yet

2 participants

@charles-dyfis-net

At present, the env-config function in langohr.core is private.

For applications which wish to accept URI-formatted configuration values, this is needlessly restrictive.

@michaelklishin
Owner

Langohr will use RABBITMQ_URL value if it is set. Is that not good enough for your case? If so, why?

@charles-dyfis-net

Local operational standards require putting all configuration in a properties file.

@michaelklishin michaelklishin added a commit that closed this issue Aug 15, 2012
@michaelklishin Expose langohr.core/settings-from, fixes #9
This is not a complete solution but addresses the reported issue
b9eef6f
@michaelklishin
Owner

I am pushing a new snapshot which exposes the URI parsing function. In addition, instead of doing our own parsing we now just let RabbitMQ Java client do it (there are tricky aspects to the way path/vhost are parsed and how the leading path slash is treated).

If that works for your case, I will push 1.0.0-beta3 tomorrow.

@michaelklishin
Owner

Also, keep in mind that it was previously possible to pass :uri in your settings map and it will be used. It can come from a properties file or anywhere else.

@charles-dyfis-net

Also, keep in mind that it was previously possible to pass :uri in your settings map and it will be used. It can come from a properties file or anywhere else.

Ooh -- I quite thoroughly missed that. Apologies for the noise (but I'm glad to see that parsing is being normalized -- fewer surprises for ops when they use the same URIs for configuring tools written in different languages).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment