Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dynamic var for the connection #51

Merged
merged 15 commits into from Apr 23, 2014

Conversation

Projects
None yet
2 participants
@ducky427
Copy link
Collaborator

ducky427 commented Apr 23, 2014

No description provided.

ducky427 added some commits Apr 20, 2014

1) Made the rest api take an explict connection argument.
2) Ported transaction ns to use that.
@michaelklishin

This comment has been minimized.

Copy link
Owner

michaelklishin commented on b4bab6a Apr 20, 2014

👍

This comment has been minimized.

Copy link
Collaborator Author

ducky427 replied Apr 21, 2014

cheers!

michaelklishin added a commit that referenced this pull request Apr 23, 2014

Merge pull request #51 from michaelklishin/connection
Removed dynamic var for the connection

@michaelklishin michaelklishin merged commit c2368c8 into master Apr 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ducky427

This comment has been minimized.

Copy link
Collaborator Author

ducky427 commented Apr 23, 2014

Thanks a lot!

@michaelklishin

This comment has been minimized.

Copy link
Owner

michaelklishin commented Apr 23, 2014

Thank you @ducky427. We now need to update the docs accordingly ;)

@ducky427

This comment has been minimized.

Copy link
Collaborator Author

ducky427 commented Apr 23, 2014

I'm working on that as well. I should have migrated the docs to neocons 3.0 soon. I think we'll need to write a migration guide as well. It shouldn't be long as the change isn't that big but it'll need to be there.

@ducky427 ducky427 deleted the connection branch Mar 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.